Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prices - top contributors now within the app #5383

Merged
merged 3 commits into from
Jun 16, 2024
Merged

feat: prices - top contributors now within the app #5383

merged 3 commits into from
Jun 16, 2024

Conversation

monsieurtanuki
Copy link
Contributor

@monsieurtanuki monsieurtanuki commented Jun 15, 2024 •
edited
Loading

What

  • We had to use the web app to list the top contributors.
  • Now we do that within the app.
  • Also added: the "contributor's prices" page.

Screenshots

top contributors button top contributors page contributor page
Screenshot_1718470551 Screenshot_1718470558 Screenshot_1718470565

Fixes bug(s)

Files

New files:

  • price_user_button.dart: Widget that displays a user, for Prices.
  • prices_users_page.dart: Page that displays the top prices users.

Impacted files:

  • app_en.arb: added 2 label for "Contributor prices"
  • app_fr.arb: added 2 label for "Contributor prices"
  • price_count_widget.dart: minor refactoring
  • price_data_widget.dart: minor refactoring using new class PriceUserButton
  • user_preferences_account.dart: local display of top users; minor refactoring using new class PriceUserButton

@monsieurtanuki
feat: prices - top contributors now locally
6c07a68 
New files:
* `price_user_button.dart`: Widget that displays a user, for Prices.
* `prices_users_page.dart`: Page that displays the top prices users.

Impacted files:
* `app_en.arb`: added 2 label for "Contributor prices"
* `app_fr.arb`: added 2 label for "Contributor prices"
* `price_count_widget.dart`: minor refactoring
* `price_data_widget.dart`: minor refactoring using new class `PriceUserButton`
* `user_preferences_account.dart`: local display of top users; minor refactoring using new class `PriceUserButton`
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner June 15, 2024 17:04
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 1.02041% with 97 lines in your changes missing coverage. Please review.

Project coverage is 7.33%. Comparing base (4d9c7fc) to head (c164d72).
Report is 196 commits behind head on develop.

Files Patch % Lines
...smooth_app/lib/pages/prices/prices_users_page.dart 1.75% 56 Missing ⚠️
...smooth_app/lib/pages/prices/price_user_button.dart 0.00% 24 Missing ⚠️
...ib/pages/preferences/user_preferences_account.dart 0.00% 10 Missing ⚠️
...mooth_app/lib/pages/prices/price_count_widget.dart 0.00% 6 Missing ⚠️
...smooth_app/lib/pages/prices/price_data_widget.dart 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           develop   #5383      +/-   ##
==========================================
- Coverage     9.54%   7.33%   -2.22%     
==========================================
  Files          325     388      +63     
  Lines        16411   19849    +3438     
==========================================
- Hits          1567    1455     -112     
- Misses       14844   18394    +3550

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon
Copy link
Member

@monsieurtanuki it might be nice adding a link to photographer, editor, contributor on the main project as well.
We also need to see if contributors are confortable with the increased visibility.

@monsieurtanuki
Copy link
Contributor Author

it might be nice adding a link to photographer, editor, contributor on the main project as well.

Sure! Please create another issue for that.

We also need to see if contributors are confortable with the increased visibility.

Fair enough.
I coded in order to solve issue #5210, and the top contributor list was already available via the web app link.
Tell me if I have to remove (or hide) that feature.
For the record in the app we only display the top 10 contributors (because I considered the "next 10 contributors" was not a priority).

@teolemon
Copy link
Member

teolemon commented Jun 16, 2024 •
edited
Loading

I got feedback from Tacite telling me it was fine.
The idea of editor/photographer/contributor was to dilute geo price data into the wider contribution opportunity.
Let's keep it to 10, those are engaged contributors who know what they are doing, and the implications in terms of visibility.

Screenshot_20240616-090010.png

@monsieurtanuki monsieurtanuki merged commit 7809854 into openfoodfacts:develop Jun 16, 2024
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon for your review and your feedbacks!

@github-actions github-actions bot mentioned this pull request Jun 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon approved these changes

@raphael0202 raphael0202 Awaiting requested review from raphael0202

Assignees

@monsieurtanuki monsieurtanuki

Labels
Prices
Projects
💸 Open Prices
Status: Done
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Status: 🎊 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replicate the 'Top Contributors' view from the Open Prices web app
3 participants
@monsieurtanuki @codecov-commenter @teolemon